[MPlayer-dev-eng] [PATCH] [REPOST] Ericsson phone remote control

Per Wigren wigren at home.se
Wed Oct 16 15:34:08 CEST 2002


I have this problem with my bmovl filter also... Some commands get dropped if 
we send them faster than the FPS.. That is not acceptable for a framebuffer 
so I think I will HAVE to make the fifo-reader a separate thread (not fork() 
though).... :(  But then I guess I can forget about it being included in 
mplayer since the developers hate threads so much...  I'd be happy to let it 
stay singlethreaded if you can tell me a better way!

Regards,
Per Wigren

Wednesday 16 October 2002 14.25 skrev Alban Bedel:
> Hello Arpi,
>
> Wednesday, October 16, 2002, 12:05:00 PM, you wrote:
> > Hi,
> >
> >> >of your code. MPlayer is a single thread application and forking for
> >> > input handler is nonsense, especially by looking at your child
> >> > process, it can be done simply without any fork, imho.
> >> >So, the patch in this form is refused.
> >>
> >> OK, but LIRC code behaves exactly like this. I'm myself hate those
> >> fork(), but though it's
> >> MPlayer'ism to write in such a way :). Would you be happier with another
> >> thread, or with select() based approach?
> >> I could do both, whatever is more relevant.
> >
> > select() is ok. threads/fork is not.
> >
> > anyway you're right, lirc.c has this fork() too, i never check that cide
> > (was not commited by me) but it's also nonsense, the old (recently
> > removed) input code also handle lirc without any fork.
> >
> > someone should fix lirc.c too.
>
>  I wrote this code. I put fork because of a limitation of the lirc
>  lib. I don't remeber exactly why. IIRC if you use select you may
>  loose some events, see the old lirc code. imho a fork is the simple
>  way to over come this. At least in this way you are sure not to loose
>  any events. I'm open to any suggestion, but i'm against any solution
>  where some events may be loose.
>
>  Albeu
>
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng




More information about the MPlayer-dev-eng mailing list