[MPlayer-dev-eng] [PATCH] update to dvb input

Arpi arpi at thot.banki.hu
Tue Oct 15 22:20:27 CEST 2002


Hi,

> attached is a small update to the dvb input patch; I added an option to
> tune by program name (read from ~/.mplayer/channels.conf)
> e.g.:
> 
> ./mplayer -dvbin on=1:prog=RaiEducational
> 
> The patch is against 15/10/2002 in cvs.

problems wiht it:

+DVBIN = yes
+ifeq ($(DVBIN),yes)
+SRCS += dvbin.c
+SRCS += dvb_conf.c
+SRCS += ts2ps.c
+else
+endif

this doesn't look ok.
the 'else' is redundant, the DVBIN = yes is hardcoded...


also it has near every variables and internal functions open, ie make them
'static', only left the really global common functions/vars non-static.

+       if(fork())

argh!


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu



More information about the MPlayer-dev-eng mailing list