[MPlayer-dev-eng] [PATCH] fixes subtitle dropouts

Arpi arpi at thot.banki.hu
Tue Oct 15 02:51:45 CEST 2002


Hi,

> This is the first patch I ever submit, so please don't shoot me right
> away. ;-)

Hey, you're part of the small group of people who send right, commitable
patches at first try! :)
so don't worry!

> All right: The patch adresses two issues which I found, when I analyzed
> the input from some DVDs with known subtitle-dropouts:

> 1. The packet-size at the beginning of the packet, which is used to
> check, whether we got all fragments, is sometimes one byte too long. It
> seems to be always padded to an even number, while the actual size can
> be odd.
Hmm. That if() was disabled/reenabled many times in the past, fixing and
breaking half of the discs... no one had the idea that it's just a padding
issue :)

It took me a while to understand part 2., but you're right with those too.
Nice work, thanks! Patch commited.

> PS: Sorry for the double post. Clicked the wrong button. (Feeling sooo 
> stupid)
:)


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu



More information about the MPlayer-dev-eng mailing list