[MPlayer-dev-eng] New videofilter: vf_bmovl.c !

Per Wigren wigren at home.se
Mon Oct 14 19:02:26 CEST 2002


Ok, maybe you like this one better... ;)
It's quite a bit faster also...

// Wigren



Monday 14 October 2002 00.13 skrev Arpi:
> Hi,
>
> > /* vf_bmovl.c v0.9 - BitMap OVerLay videofilter for MPlayer
>
> the code looks ok, but i have some doubts over portability:
> > #include <inttypes.h>
> >
> > #include <sys/types.h>
>
> afaik sys/types.h is not everywhere available, and anyway inttypes.h
> contains the same typedefs and is mandatory anyway for mplayer
> (and there is fallback one in etc/inttypes.h)
>
> > 		int nbytes;
> >
> > 		if (ioctl (vf->priv->stream_fd, FIONREAD, &nbytes)) {
> > 			printf ("Got ioctl() error on the FIFO\n");
> > 			perror ("fionread");
> > 			return vf_next_put_image(vf, dmpi);
> > 		}
>
> wtf is this? why don't you use select() or just nonblocking read() and
> check its return value?
>
>
> A'rpi / Astral & ESP-team
>
> --
> Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vf_bmovl.c
Type: text/x-csrc
Size: 14045 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20021014/1c35dd4e/attachment.c>


More information about the MPlayer-dev-eng mailing list