[MPlayer-dev-eng] [PATCH] another batch of compilation warnings fixes (GUI too)

[Dominik Mierzejewski]

On Thursday, 10 October 2002, Arpi wrote:
> Hi,
[...] 
> no, it's much simpler: just add const to devname decl.

Of course. :-)

> > Oh, and I've attached some patches to fix other warnings and one thing I
> > thought could be done better:
> > Gui/mplayer/gtk/fs.c:
> > -   if ( ( name[i] >='a' )&&( name[i] <= 'z' ) ) { tmp[c++]='['; tmp[c++]=name[i]; tmp[c++]=name[i] - 32; tmp[c++]=']'; }
> > +   if ( isalpha(name[i]) ) { tmp[c++]='['; tmp[c++]=name[i]; tmp[c++]=name[i] - 32; tmp[c++]=']'; }
> 
> is ctype.h standard on all mplayer-supported playforms?

Good question. I haven't thought about it. But I'm sure it's in the ANSI C
standard, so it should be included with all ANSI compliant compilers and
since we require gcc (which is ANSI C compliant), I think the answer is
yes.

> > - int             i;
> > +/* int             i;*/
> unused? unsure?

Unused.
 
-- 
MPlayer RPMs maintainer: http://www.piorunek.pl/~dominik/linux/pkgs/mplayer/
"The Universe doesn't give you any points for doing things that are easy."
        -- Sheridan to Garibaldi in Babylon 5:"The Geometry of Shadows"