[MPlayer-dev-eng] [iyhi at yahoo.com: [MPlayer-users] mplayer: [BUG REPORT AND PATCH] mp3lib: synth_1to1_pent() SIGSEGV]

[Michael Niedermayer]

Hi

On Tuesday 19 November 2002 19:17, Gabucino wrote:
> What about this patch? It was sent to the wrong address.
hmm, the code in decode_i586.c is certainly broken but the patch doesnt really 
improve it that much IMHO ...

the problems before the patch are: 
1. acessing arrays with "m"(...) is risky as gcc can copy the first element on 
the stack AFAIK and use this instead, allthough "m" (array) style is fairly 
common
2. "%ebp" on the clobberlist (gcc is buggy and cant handle that AFAIK) though 
it might work with -fomit-frame-pointer

the problems after the patch:
1. still there
2. mostly solved (ebp is still on the clobberlist though)
3. push/pop ebp -> changes esp (and access "m" style variable which can be on 
the stack which can be accessed with esp -> ooops if -fomit-frame-pointer IS 
used)

Michael