[MPlayer-dev-eng] bug in passthrough in vf_rotate/vfilter layer in general

[Balatoni Denes]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi!

I have been looking at this for the last 4 hours, but couldn't solve the 
problem.

So if I use "mplayer -vop rotate 6 divx50encodedlandscape.avi" all I get is
grey screen with vo_xv and black screen with vo_fbdev (in this case vf_rotate
should be a passthrough vfilter).
Without -vop rotate it plays percfect.
If I try a portrait movie with rotate, it is rotated and played correctly.

If I try to play a landscape mpeg1/2 video with -vop rotate=6 , there is
picture, but movie is skipping (the movie is small, and I have a p4 1.5 so it 
can't be normal). Without -vop rotate it works perfect.

I also tried changing vf_rotate so that all its functions are the default, to 
make it a nop vfilter ->  but than I got black/grey picture, so this 
passthrough thing is not working perfect.
Actually this can all be worked around if I put another filter in front of or 
after rotate, like -vop rotate=6,scale=-1:-1 or crop=320:144 instead of scale 
- - passthrough seems to work in those cases well.

So there must be a bug somewhere, I was looking at vf_get_image, and vf.c, 
but I found that whether it's passthrough or not the same things gets passed 
to vf_get_image, and vf_vo gets the same things too. Maybe I overlooked 
something, or the problem is somewhere else.

If you have any ideas or comments, they will be greatly appreciated!

bye
Denes

- -- 
"Use the source Luke !"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.4 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE92tD0aQToeq3jgogRArA3AJ4mKgLLaS6O3uaKHl2YdKpYjmoUkgCeMxZ6
/GdRsPP7XKqE9QVdksmGORw=
=51Ub
-----END PGP SIGNATURE-----