[MPlayer-dev-eng] [PATCH] xvid_vbr.c assume .avi output

[Arpi]

Hi,

> The XViD VBR library assume .avi output and tries to compensate the
> .avi overhead in the 2nd pass with this code : (line 780)
> 
> 	/* Compensate AVI overhead */
> 	desired = state->desired_size -  state->nb_frames*24;
> 
> IMHO it's not a good idea. For example I prefer to use the .ogg/.ogm
> container and most of the time I add multiple audio streams, which
> means the overhead is probably not 24 bytes per frame. And in the
> futur we will probably be using another container with different
> overhead etc...
> 
> The libavcodec mpeg4 codec doesn't try to compensate the container
> overhead. I don't know if divx4 / divx5 does or not.
> 
> What do you think ? Should we discard this line or not ?

Imho discard.
For example, mencoder compensates container overhead when calculating
recommended bitrates at the end of audio-only 1st pass. It's teh job of
the demuxer, not the codec.


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu