[MPlayer-dev-eng] [PATCH] Initial Real Audio ATRAC3 Support / atrc.so.6.0 - Needs more testing (?)

[Arpi]

Hi,

> I am slowly beginning to feeling stupid ...
:)

btw

> -typedef struct {
> -    int samplerate;
> -    short bits;
> -    short channels;
> -    int unk1;
> -    int unk2;
> -    int packetsize;
> -    int unk3;
> -    void* unk4;
> +typedef struct radecoder_init_params
> +{
> +	int		sampleRate;  // 4
> +	short		bitsPerSample; // 2
> +	short		channels;  // 2 
> +	short		audioQuality; // 2
> +	int		bitsPerFrame; // 4

you should have a short unused; there, or change audioQuality to int.
now gcc aligns bitsPerFrame to 4-byte boundary, but it's compiler dependent
and we shouldn't rely on such sideeffects...

and, where do these names (bitsPerFrame etc) come from?
from the Helix source/docs or did you find them out by R.E.?


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu