[MPlayer-dev-eng] [PATCH] ve_xvid bug fixes, cleanup & enhancements

[Anders Rune Jensen]

On Sat, 2 Nov 2002 16:28:01 +0100
Rémi Guyomarch <rguyom at pobox.com> wrote:

> 1) It seems the CONF_TYPE_SUBCONFIG array for the "mode" option eats
>    all other -xvidencopts parameters. With it it wasn't possible to
>    set the bitrate or in fact any other parameter beside "mode".
> 
> 2) xvidenc_param declared static, no need to pollute the name space.
>    It will be probably nicer to convert to a set of static variables
>    like in ve_lavc.c (easier to initialize) but I will do it in
>    another patch if needed.
> 
> 3) xvidencopts_conf wasn't properly initialised for some of the
>    lines. Probably didn't cause bugs but at least this patch shaves a
>    few gcc warnings.
> 
> 4) Added "lumi_mask" & "mpeg_quant" options.
>
> 
> 5) Changed the interpretation of "br" to be consistent with lavc (now
>    in kbits/s if <16000, else bits/s). Should be backward compatible.

I just tried your patch. I still can't go above 800kbit bitrate. Had
the same problem with current cvs.

My options are:

mencoder ../matrix.vob -oac copy -ovc divx4 -vop
scale=576:-2,crop=720:422:0:78 -xvidencopts br=1400:mode=2pass-1 -vop
pp=lb -sws 10 -ssf ls=1 -o matrix-xvid.avi

mencoder ../matrix.vob -oac copy -ovc divx4 -vop
scale=576:-2,crop=720:422:0:78 -xvidencopts br=1400:mode=2pass-2 -vop
pp=lb -sws 10 -ssf ls=1 -o matrix-xvid.avi

-- 
Anders Rune Jensen