[MPlayer-dev-eng] Aprobation for spu/vobsub patch

Alban Bedel albeu at free.fr
Mon May 27 00:58:25 CEST 2002


Hi Felix Buenemann,

on Sun, 26 May 2002 23:49:12 +0200 you wrote:

> On Thursday 16 May 2002 17:23, Alban Bedel wrote:
> > Hi,
> >
> > I hacked the spu/vobsub system in order to make it better for vo which
> > support hw spu. The main change is to remove the integrated spudec in
> > vobsub and create the spudec only if needed (ie. when vobsub or dvd
> > subtitles are used). Also the vobsub/spudec init had to be moved after to
> > vo init, because we need to know if the vo support hw spu or not. I also
> > add VOCTRL_SET_SPU_PALETTE to send the palette to the vo if it support hw
> > spu.
> > So as the subject imply I'm waiting comments/sugestions before going
> > further.
> do you want me to test it with vobsub without spu hw? or you already checked 
> with vobsub and dvdsub?
> Your approach seems fine to me from the description.
This is alredy in cvs in another better version (far less change in mplayer.c).
Also vobsub should be working for dxr3 now (they are for dxr2), anyone can
test ?
	Albeu



More information about the MPlayer-dev-eng mailing list