[MPlayer-dev-eng] [PATCH] volume control with ao_sdl

[Anders Johansson]

Hi,

> On Sat, 25 May 2002 12:53:11 -0400 D Richard Felker III
> <dalias at aerifal.cx> wrote:
> 
> Hi,
> 
> > IMO this was a bad patch. All it did was implement software mixing
> > using SDL's function for software mixing.
> 
> Ok, but does it break anything ?
> 
> > That functionality is
> > already provided through the soft mixer ao plugin.
> 
> Either I'm a luser, either it works as it wants :
> 
> a) With some movies I got things like:
>  AO: [plugin] 44100Hz 2ch Signed 16-bit (Big-Endian)
>  [pl_volume] Audio format not yet suported 
>  couldn't open/init audio device -> NOSOUND
>  Audio: no sound!!!
Use format plugin to fix this. I am interested in this movie can you
send it to me. Also what platform are you using?

> b) Specifying volume via command-line isn't very user friendly ;-)
Only initial volume setting. When movie is playing the volume is set
with * and / as usual (I will add this to the manual). 


But I think the patch is a very good thing anyway since the native
volume control always is better than the software one I wrote (you get
better SNR).

Cheers,
//Anders