[MPlayer-dev-eng] [PATCH] (retry) avoid referencing freed pointers in gtk gui code.

[Matijs van Zuijlen]

Hello,

A few days ago I sent a patch for a problem I had with the gui code. I
just started using mplayer and I like it a lot: The playback is very
smooth. However, I could not load files using the gui: After selecting a
file in the dialog, the filename the program tries to load is garbage.
The result is that the gui is all but useless for me.

I tracked this problem down to the fact that the filename is copied from
the Gtk clist that holds it after that clist has been destroyed. To
solved this I moved the code that destroys the dialog down to after the
name is copied.

Like I said, I already sent this patch a few days ago. However, there
has not been a response yet. Does this mean it has been rejected, or
just that nobody looked at it yet? I'm new here, so please cure my
cluelessness :-).

TIA,

-- 
Matijs van Zuijlen

    ... designed to fill holes or cracks of not more than two cubic vims.
			    -- Robert Sheckley, Untouched by Human Hands
-------------- next part --------------
Index: Gui/mplayer/gtk/fs.c
===================================================================
RCS file: /cvsroot/mplayer/main/Gui/mplayer/gtk/fs.c,v
retrieving revision 1.12
diff -u -r1.12 fs.c
--- Gui/mplayer/gtk/fs.c	14 May 2002 11:40:59 -0000	1.12
+++ Gui/mplayer/gtk/fs.c	18 May 2002 19:30:40 -0000
@@ -336,8 +336,6 @@
    return;
   }
 
- HideFileSelect();
-
  switch( fsPressed )
   {
    case 1:
@@ -375,6 +373,9 @@
           guiSetDF( guiIntfStruct.Othername,fsSelectedDirectory,fsSelectedFile );
           break;
   }
+
+ HideFileSelect();
+
  item=fsTopList_items;
  while( item )
   {