[MPlayer-dev-eng] [BUG] bug in vo_png?

Alex Beregszaszi alex at naxine.org
Wed May 15 18:13:05 CEST 2002


Hi,

> try to remove this bad code:
> 
>   /* hack: swap planes for I420 ;) -- alex */
>   if ((image_format == IMGFMT_IYUV) || (image_format == IMGFMT_I420))
>   {
>     uint8_t *src_i420[3];
> 
>     src_i420[0] = src[0];
>     src_i420[1] = src[2];
>     src_i420[2] = src[1];
>     src = src_i420;
>   }
> 
> it swaps U<->V while it shouldn't, according to DOCS/tech/colorspaces.txt
Also this code was added before new filter layer, so it was fine :)

Hm, all the vo drivers should be revised before release - or at least before
1.0 release.

-
alex



More information about the MPlayer-dev-eng mailing list