[MPlayer-dev-eng] Re: [PATCH] DXR2 video output

[Alban Bedel]

Hi Tobias Diedrich,

on Mon, 13 May 2002 14:43:11 +0200 you wrote:

> Arpi wrote:
> 
> > you shouldn't include yv12->mpeg1 conversion in the vo driver, it's now
> > handled by vf filters (fame, lavc)
> 
> Hmm, I'll look into that. Would it be the right thing to put frame rate
> conversion into the vf filters too ? (The card can only do 25fps or
> 29.97fps, so 23.97fps has to be converted by doubling every 24th or
> every 4th frame). Also it can only handle a few sizes (w=352 or 704 or
> h=240 or 480 at 29.97fps, h=288 or 576 at 25fps) so it IMHO would be
> better to automatically select the right one and not depend on the user
> to supply the right parameters to the plugins...

I got a dxr2 this weekend and tested your patch. First I saw that your patch depend
on another patch that you send to the dxr2 driver list, so put I these parts inside
#if 0 blocks. I removed the included encoder, added many options and overlay
support.
I also tried to add support for hw audio decoding but failed. Either the sound or
the video was always choppy :(

Some notes about the overlay :
I needed overlay support as I don't have a TV. I looked in the little player included with
the dxr2 driver, and in order to init the overlay the dxr2 need a white screen. So I simply
use an other mplayer vo driver to do this (It must support BGR24). The overlay is on by 
default but if you don't supply a subdriver it can't use it, so it won't be enabeled.
So "mplayer -vo dxr2 -ao dxr2 my.mpeg" will not use the overlay but
"mplayer -vo dxr2:x11 -ao dxr2 my.mpeg" will (under X :)
	Albeu