[MPlayer-dev-eng] [PATCH] DXR2 video output

[Dominik Mierzejewski]

On Friday, 10 May 2002, Tobias Diedrich wrote:
> This patch adds DXR2 video + audio output plugins
> (based on mpegpes output plugin).
> configure will autodetect it if the headers are in
> /usr/src/dxr2/sysinclude

Why not /usr/include/dxr2? Or /usr/local/include/dxr2?
Your default is uncommon and not really FHS compliant.

> It adds the switch --with-dxr2incdir to change this path.
> It also adds two new cmdline switches:
> -dxr2norm NORM and -dxr2ucode PATH_TO_UCODE_FILE
> (The default for former depends on the resolution and is pal
> for h==288 || h==576, the latter has /usr/src/dvd12.ux as default)

Again, why /usr/src? /usr/lib/dxr2 or /usr/local/lib/dxr2 would be
a better default IMVHO.

Also, please check your patch again, it looks to me that the second
part reverses some changes made to ./configure by the first part.
 
-- 
MPlayer RPMs: http://msp-190.man.olsztyn.pl/~dominik/mplayer.html
"The Universe doesn't give you any points for doing things that are easy."
        -- Sheridan to Garibaldi in Babylon 5:"The Geometry of Shadows"
Dominik 'Rathann' Mierzejewski <rathann(at)rangers.eu.org>