[MPlayer-dev-eng] Re: [PATCH] Read extended (>2GB) AVI files

Wolfram Gloger wg at malloc.de
Thu May 9 19:52:22 CEST 2002


>yes, but your conversions from int to long are bad, as long is 64bot on
>64bit cpus like alpha, while it's 32bit on 32bit cpus liek x86

I am well aware of that, thank you very much.  Please point out where
exactly such a "bad conversion" is in the patch, and I will certainly
fix it.  However, there is not a single conversion from an int to a
long variable, just the necessary ones to off_t, for compatibility
with the demuxer_... interface, which is (correctly!) 64bit if
--enable-large-files is used.  Also some casts to unsigned if a value
that could be >2GB is used.

Regards,
Wolfram.




More information about the MPlayer-dev-eng mailing list