[MPlayer-dev-eng] bogus overloaded quality var for mp3lame encoding

[Felix Buenemann]

On Wednesday 01 May 2002 06:22, D Richard Felker III wrote:
> Overall, this whole situation seems to be entirely broken. These two
> settings, "VBR quality" and "algorithmic quality", have nothing to do
> with one another, and need to be configurable independently, so "q"
> should not control both of them. I'd like to ask permission to fix
> this, since changes may affect compatibility with old command line
> syntax.
>
> I doubt many people have used CBR so far (especially since it doesn't
> work with WMP or whatever), so it would probably be acceptable to just
> make "q" control VBR quality, and mode the LAME algorithm quality
> setting to another option. But if this isn't ok, how about the
> following setup:
IMHO win + cbr has been fixed recently.

>
> Have two new separate variables, VBR quality and the other quality,
> both initially -1. Export them as options so they can be configured by
> the user. But, if they're still -1 when it gets to time to initialize
> LAME, initialize them in the old (brain damaged) way based on "q".
> Make sense?
no, that'd be silly. Make a new parameter for the algorithmic quality and 
leave q for vbr quality control.

-- 
Best Regards,
        Atmos
____________________________________________
- MPlayer Developer - http://mplayerhq.hu/ -
____________________________________________