[MPlayer-dev-eng] [PATCH] Realplayer codec support

[Florian Schneider]

Arpi wrote:
> Hi,
> 
> 
>>I have put the codecs and an example real medai file into
>>/incoming/realcodecs
> 
> 
> i've checked, very nice job.

Thanks ;)


> 
> but, are you sure your demuxer extensions are working and complete?

Honestly, I think it's complete, but I am not sure. I have tested the
input data for the Transform and CustomMessage calls when playing
from RealPlayer and from mplayer. They are the same (except some values
that the decoder might use, but I didn't find out). The input data is 
exactly the same (tested it with some kind of crc), but the output 
differs. Hence I think the demuxer might be correct, but the codec 
doesn't get the some other incorrect information.

> the sample file you uploaded plays buggy, but i don't think it's a
> codec problem, it shows the same kind of problems like some .asf files
> using unimplemented (in demux_asf.c) subpacket types. (note, that asf and
> real are somehow close, at least the asf v2 paper is co-authored by
> microsoft & realmedia, and anyways the file formats has similar parts)
> 

Hmm... that's interesting. I will take a look at it.

> so, imho the codec is working, but there are problems with the demuxer.
> did you compare packets byte-by-byte of mplayer demuxer and realplayer ?
> 

No, only crc for the input stream content. I also compared length of the 
blocks, number of subpackets for the block and the timestamp. All are equal.

> also, i've tried on some other rv30 files (at mplayerhq.hu ftp samples/ dir)
> and some of them crashed teh demuxer, others just show no pics at all or
> very buggy flickering stuff.

That's one of the reason I wanted to release the patch before it's 
working flawlessly.
At home I am testing the patch with other .r(a)m files. RV20 doesn't 
work yet, but I'm analysing it. Also the files have (at least) 2 32bit 
integers to describe the format. In the published patch I have hard 
coded them, which I have fixed yesterday, but I want the patch to be 
working - i.e. not crashing - except dor the ugly playback, which will 
take longer and I can't probably fix alone.

> 
> or, maybe we should pass more per-packet info from the demuxer to the codec?
> 
> afaik the file format of .rm is public, at least Alex used it to write
> demux_real.c afair. Alex, do you still have that file?
> 

BTW: Is the Real SDK on the ftp server? I haven't found it on that thing
RealNetworks calls homepage.

Regards

Flo