[MPlayer-dev-eng] [PATCH] Bug in configure (EXTRA_INC)

Arpi arpi at thot.banki.hu
Tue Jul 30 21:02:35 CEST 2002


Hi,

> corrects bug that makes appears : -I-I in (g)cc options.
> (-I is already present in $_dvdnavdir)
not always:(

>    if test -n "$_dvdnavdir" ; then
> -   _inc_extra="$_inc_extra -I$_dvdnavdir"
> +   _inc_extra="$_inc_extra $_dvdnavdir"
>    fi

it fixes detection by dvdnav-config but break other ways...

_dvdnavdir=`echo $ac_option | cut -d '=' -f 2`
...
_dvdnavdir=`$_dvdnavconfig --cflags`
...
cc_check $_inc_extra -I$_dvdnavdir  ...

so, we should decide how to fix it...
i think _dvdnavdir should not contain the -I, but there should be _dvdnavinc
which contains -I and uses te output of $_dvdnavconfig

w8ing for a better patch :)


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu



More information about the MPlayer-dev-eng mailing list