[MPlayer-dev-eng] Re: [PATCH] xv-options (brightness etc)

[Nick Kurshev]

Hello, PАsztor!

On Tue, 22 Jan 2002 12:31:32 +0100 (CET) you wrote:

> Nick:
> > I've applied this patch after serious modifcation it.
> > If it will cause problems - please comment out set_gamma_correction() call
> > in init() function of vo_xv.c
> 
> Hm :) it doesn't seem to work.
If I applying patch - this mean that it works at least for me ;)
> The function calls are missing in mplayer.c. How is it intended to be used?
> Now the user can't control the settings with keys 1-8.
> 
It significand problem but we should solve it later after fixing NVidia probs.
Currently uou can use it as command line arguments:
mplayer -vo xv -brightness 400 -saturation -100 -hue 300 ...
Every gamma parameter can be changed from -1000 upto +1000 range.
> My other issue with it: the SET_XV_DEFAULTS setting is very necessary imo.
> This trigger made sure that upon mplayer start, the xv things are reset.
Does it exists with every X11 driver?
> Otherwise the control gets out of hand (because values inside mplayer are
> all reset to 50) and after a 2nd start, it is easy to crash the player with
> BadValue errors. Init used this setting-to-default and it needed
It's impossible since programs checks for "port" existance.
> SET_XV_DEFAULTS to be the first in the structure.
> 
> 3rd issue: The structure was meant to be expandable. That is, if any new
> attribute is needed, it is (was :)) enough to make a new entry in the struct
> for it.
My patch is expandable too ;)
> 
> s.
> 
>             -------------------------------------------------------
>             |  It's all fun and games till someone loses an eye;  |
>             |         Then it's fun, just you can't see.          |
>             -------------------------------------------------------
> 
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
> 


Best regards! Nick