[MPlayer-dev-eng] Re: [PATCH] Development (Was: Clean up

[Daniel Egger]

Am Die, 2002-02-26 um 02.39 schrieb Arpi:

> it IS readable. for the author of the code.

Wow, that's nice. And everything that would make it readable to others
is a bug and thus rejected.

> > Spaghetti code. Easy to get it wrong, hard to read.
> descriptive answer...

Cool, eh? Simple, and elegant...
 
> anyway your profiles were bad.

Sure, and were's the proof?

> mplayer calls demuxer functions a lot
> _before_ the actual playback starts. in playback loop it's called just a few
> times per second, so your "fix" won't speed up playback at all.

It does, not much for video but definitely for audio.

> anyway gprof and other profilers can't show this difference...

Really? You'd be surprised what gprof can show....

> anyway 2: gcc and other c compilers compile switch {...} to function pointer
> array and indexes in it at the pace of your switch(). so i can't see why
> is your version faster?

Depends on the platform, the compiler, the cpu and the day of the month.

> feel free ... to send it to /dev/null
> again: cosmetics is not welcomed here.
> fork if you want to do cosmetics.

again: I won't form mplayer. I've no idea why you're so keen on it.

> sorry if being rude, but i see from yoru first mail that you will never send
> any usefull lines of contribution. yo ureminds me to someone who ran html
> docs through some html tidy program and send us big patch...

No, the HTML docs are so ugly I'd rather start from scratch.

> just imagine what would happen if everyone starts to chaneg style of code...

Just imagine what would happen if all core developpers agreed to a style
and actually put it in words.

> then it would keep changing all time which breaks all diffs and make it more
> difficult to read by its maintainer/author.
> the other way is forcing a given indenting/coding style and force everyone
> to use that. but no one will like this...

You're obviously missing the point.
 
-- 
Servus,
       Daniel