[MPlayer-dev-eng] Re: [PATCH] Development (Was: Clean up demuxers)

Mike Melanson melanson at pcisys.net
Tue Feb 26 02:27:22 CET 2002


On Tue, 26 Feb 2002, Arpi wrote:

> > problem with reckless declaration of new scopes at random places in the
> > code simply because the programmer wanted another local variable right
> > there. Now that's just sloppy.
> 
> I still can't see the problem with this

	While a piece of code may be technically valid, and may even
compile without warnings, that doesn't make it understandable. IOW, just
because you *could* doesn't mean you *should*. E.g., just because we
*could* actively maintain a Windows port of MPlayer doesn't mean we
*should*...:)

	Bottom line: Properly written and organized code lends itself to
readability, understanding, functionality, and maintainability, all
without impacting program performance.

> > subsystem needs help (almost as much as the decoding subsystem needs help,
> > but that's another thread...:)
> i'm working on that right now

	Really? So was I. We should really compare notes sometime...:)
-- 
	-Mike Melanson




More information about the MPlayer-dev-eng mailing list