[MPlayer-dev-eng] Re: [PATCH] Clean up demuxers

[Daniel Egger]

Hija,

> > > - you changed int to unsigned int?
> > > Because it's cleaner and leaves the compiler with more optimisation
> > opportunities.

> rotfl

You haven't lost your sense of humour. Being a gcc hacker I can actually
prove the above said if you don't believe it, though that would be 
not within the scope of this mailinglist.


> > > - renamed variable demuxer to demux (resulting big cosmetics patch)
> > To find all offending places.
> heh ?

Yes, changing a variable-/typename is a very effective way to find
referers in the code.

> it is included from many files since it was written...

But the structure was not used from mplayer.c until recently. At least
when I originally did the changes it didn't.

> i can't see any functionality.

It's a different and faster approach to schedule packets to the right
demux. Maybe we've a different understanding of functionality but it's
clearly not just a cosmetic change.

> no one asked this

Thanks a lot.

> > use a function pointer?
> > Don't ask me. My job is optimisation and cleanup and not swinging 

> the job?

Ok, let's rather call it a mission. mplayer was the first multimedia
player that ever was fast enough to play DVDs and DivX on my PowerBook
(after writing some faster AltiVec routines for ffmpeg in assembly). 
And since I discovered your great work I wrote a few little patches
to improve it another bit and I'd like to continue if I may; as soon
as the new gcc is out I'll release my AltiVec code to the public 
(the old version needed a special version of the binutils to be useful
 or Motorolas broken gcc with Altivec extensions).

> let's fork then...

Nah, I'd rather not do this again.

> > big crystal orb. If you can do it cleanly and it will lead to the same
> > speed I'm fully satisfied and will go back from where I came from.

> if you are so big wonderfull perfect experienced programmer, why does
> single fnction pointer mean crystal orb compared to function pointer
> array ?

I simply don't understand where you would want to use a single function
pointer here contextwise and therefore I'd need a crystalorb or a few
more words from you to incorporate your suggestions. Would you, please?

-- 
Servus,
       Daniel