[MPlayer-dev-eng] Re: [PATCH] Clean up demuxers

[Arpi]

Hi,

> > could you explain, why 
> > - you changed int to unsigned int?
> 
>  Because it's cleaner and leaves the compiler with more optimisation
>  opportunities.

rotfl

> > - renamed variable demuxer to demux (resulting big cosmetics patch)
> 
>  To find all offending places.

heh ?

it reminds me to Ingo's new scheduler kernel patch... really.

> > - added static array to demuxer.h ?
> 
> Because it was formerly only used by demuxer.c but now isn't anymore
> (whyever) and thus is global.

it is included from many files since it was written...

> > i really don't like this patch. it has no real value but does big cosmetic
> s
> > changes which is not welcomed here.
> 
> This makes me curious. From reading most of the code one can clearly see
> that this is a lot of cut'n'paste work from a guy who has cleary little

rotfl 2

yea, i like to cut'n'paste my code from the same file just to make it ugly.
heh.

> programming experience. Sorry, but its such a rubbish in parts that I
> already though about giving programming lessons here. Any cleanup should
> be well appreciated if it also contains functionality changes which my
> patch clearly provides.

i can't see any functionality.

> Love it or leave it. Run my code through your code uglifier if you can't
> stand some programming but I will NOT ever write obfuscated source just
> to match someones personal ego.
no one asked this

> > anyway, you're right in one thing: that big switch(){...} is not good, and
> > slow. it was added when there were 3 demuxers... now there are 18...
> > anyway, i don't like the method you used to solve this. why don't we simpl
> y
> > use a function pointer?
> 
> Don't ask me. My job is optimisation and cleanup and not swinging the
job?
let's fork then...

> big crystal orb. If you can do it cleanly and it will lead to the same
> speed I'm fully satisfied and will go back from where I came from.
if you are so big wonderfull perfect experienced programmer, why does
single fnction pointer mean crystal orb compared to function pointer array ?


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu