[MPlayer-dev-eng] new changes to input trash terminal on exit

D Richard Felker III dalias at aerifal.cx
Sun Feb 24 06:03:33 CET 2002


On Sat, Feb 23, 2002 at 11:02:44PM -0500, D Richard Felker III wrote:
> some of the new changes in the input system today broke mplayer so it
> trashes the controlling terminal on exit (it leaves echo mode
> disabled when it exits). this should be fairly simple for alban to fix
> since he's familiar with the changes he made, but i'll take a look and
> see if i can fix it if he's not around now.

ok, it appears to be fixed now, but i had to disable an early
initialization of getch2 that was added in alban's commit. i'm not
quite sure why this was there -- it seems to work without it. if this
needs to be put back, then more code needs to be put in place to
prevent multiple initializations of getch2 (which overwrite the saved
terminal status that needs to be restored on exit), or else mplayer
needs to be changed so that getch2 is only initialized once at
startup, and then disabled only once at exit. imo this latter solution
makes a lot more sense, but i didn't want to make large scale changes
like that to fix this simple bug.

rich





More information about the MPlayer-dev-eng mailing list