[MPlayer-dev-eng] [PATCH] mga_vid memleak fix

[D Richard Felker III]

ok, i'm trying to work on the patch, but i've encountered a strange
problem. when i add:

  static uint32_t mga_top_reserved = 0;
  MODULE_PARM(mga_top_reserved, "i");

mga_vid builds fine, and i can load and use the new option with
insmod, and it works correctly. however, modprobe doesn't like it:

  /lib/modules/2.4.12-ac3/mga_vid.o: invalid parameter parm_mga_top_reserved
  /lib/modules/2.4.12-ac3/mga_vid.o: insmod /lib/modules/2.4.12-ac3/mga_vid.o failed
  /lib/modules/2.4.12-ac3/mga_vid.o: insmod mga_vid failed

the error only occurs when i have the following in modules.conf:

  options mga_vid mga_top_reserved=0x10000

but without something like this being present the patch isn't much
good. any idea what might be wrong?

rich



On Mon, Feb 04, 2002 at 08:36:30PM +0100, Attila Kinali wrote:
> On Sun, 3 Feb 2002 22:49:52 -0500
> D Richard Felker III <dalias at aerifal.cx> wrote:
> 
> 
> > anyway, my console is usually 1024x768, but the same happens at
> > 640x480 and perhaps other sizes. whether the corruption takes place or
> 
> At which bpp ? I tryied a 720x548 movie and hadnt any probs, maybe it's
> the fastdraw option.
> 
> > > Juup, that sound far better.
> > > Also the "save memory" could be done as an option
> > 
> > should i write a patch and send it?
> 
> Sure.
> 
> 		Attila Kinali
> 
> -- 
> I am a moslem, i am a terrorist.
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng