[MPlayer-dev-eng] [PATCH] mga_vid memleak fix

[Attila Kinali]

On Sun, 3 Feb 2002 12:38:17 -0500
D Richard Felker III <dalias at aerifal.cx> wrote:


> i've already patched my copy, but i've probably skipped too much
> memory -- i don't know exactly how much matroxfb needs for the font.
> is it ok to lose say 16k or so to ensure that we stay a plenty far
> away even when there's a fairly large font?

Make it a compile time option, people with just 8mb ram need every byte.

IMHO the proper way would be to store the memory range before overwrting
it and restoring it after closing the char driver.
But this shouldnt be done with kmalloc, but rather with vmalloc
(we dont need physical continous memory for a buffer).
If implemented this should also be a compile time option.

		Attila Kinali

-- 
I am a moslem, i am a terrorist.