[MPlayer-dev-eng] [PATCH] new config parser related warning fixes (for GUI, too)

Arpi arpi at thot.banki.hu
Sun Dec 29 22:01:23 CET 2002


Hi,

> These fix the following warnings:
> 
> Patch #1:
> cfg.c:184: warning: passing arg 2 of `m_config_register_options' from incompatible pointer type
> cfg.c:249: warning: passing arg 1 of `m_option_print' from incompatible pointer type
> 
> Patch #2:
> mplayer.c:643: warning: passing arg 2 of `m_config_register_options' from incompatible pointer type
> mencoder.c:397: warning: passing arg 2 of `m_config_register_options' from incompatible pointer type
> input.c:1454: warning: passing arg 2 of `m_config_register_options' from incompatible pointer type
> 
> OK to commit?

not...

afaik the new config code is backward compatible to the old one, so these
warnings shouldn't happen at all. Albeu ?

also, the old config will be removed *soon*, so adding thse #ifdefs are
pointless.

btw, when will be it removed? Albeu ?
there are 2 releases out with the new config enabled, and the bugs were
fixed, so no much sense to keep the old one and the compatibility hacks.
anyway the new one doens't print notices or detailed info of syntax errors
like the old one, so it needs still improvement :(


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu



More information about the MPlayer-dev-eng mailing list