[MPlayer-dev-eng] [BUG] CDDB://

[Arpi]

Hi,

there is /dev/cdrom hardcoded in cddb.c:63:
read_toc(void) {
        int drive = open("/dev/cdrom", O_RDONLY | O_NONBLOCK);
...

it triggers a bug later:

        char offsets[1024], command[1024];
        ptr = offsets;
        for( i=0; i<cddb_data->tracks ; i++ ) {
                ptr += sprintf(ptr, "%d+", cdtoc[i].frame );
        }

the string 'offset' will be uninitialized if cddb_data->tracks<=0


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu