[MPlayer-dev-eng] [PATCH] mplayer fails to link with newer binutils

[Soeren Sonnenburg]

On Sun, 2002-12-22 at 03:12, Soeren Sonnenburg wrote:
> On Sun, 2002-12-22 at 03:18, Arpi wrote:
> > Hi,
> > 
> > > Would be nice to see this fixed in the upcoming rc2
> > agree.
> > but we cannot reproduce so cannot fix it
> 
> wait, you don't get any warnings like
> /usr/bin/ld: mp3lib/libMP3.a(sr1.o)
> unresolvable relocation against symbol `decwin'
> when linking ? even with the older binutils ?
> 
> Fixing this warning fixes the bug.

Ok, I've had a look at this... it seems to be a conflict in the
definitions of decwin, once as long[512+32] (MMX version) and once as
real[512+32] (non-MMX).

If one compiles for MMX it helps to remove the #include "tabinit.c" in
sr1.c. However I could not test compilation *without* MMX...
--disable-MMX{,2} didn't do anything...

So if someone knows the proper #ifdef MMX #endif around this include its
fixed...

Index: sr1.c
===================================================================
RCS file: /cvsroot/mplayer/main/mp3lib/sr1.c,v
retrieving revision 1.24
diff -r1.24 sr1.c
53d52
< #include "tabinit.c"

Soeren.