[MPlayer-dev-eng] [PATCH] XMMS inputplugin V2.0

[Arpi]

Hi,

> 
> > > Playing x.xm
> > > XMMS song title='(null)' length=-1
> > > Waiting for the XMMS plugin to start playback of 'x.xm'...
> >
> > ok after finding & changing /usr/lib hardcoded in demux_xmms_pluginenum.c
> > too, i got it work. no seeking, through.
> mikmod plugin can't seek

it's xmp not mikmod.
i don't have mikmod plugin at all.
and xmms gui can seek, only mplayer can't.

> > you should add error checking (it seems it returns length==0 for
> > nonseekable and -1 for error (cannot handle - no plugin))
> -1 is non seekable imho (in which case seekable is set to 0) , 0 is I don't 
> know what.
i got -1 when it didn't find plugin. now i get 0, it plays but no seeking.

> If input_get_time returns -1 than song ends. If plugin couldn't load the file,
> input_get_time will return -1, and so it will exit.
no, it's busy looping in the lien i shown you:

  init_plugins();
  xmms_output_plugin.init();
  input_get_song_info(demuxer->stream->url,&xmms_title,&xmms_length);
  if (xmms_length<=0) demuxer->seekable=0;
  input_play(demuxer->stream->url);  // this probably fails!!!
  while (xmms_channels==0) usleep(10000); // endless loop here

it'll never exit if error.

also i get hangup at quit (pressd 'q') now.


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu