[MPlayer-dev-eng] [PATCH] a couple of warning fixes in qt decoder and encoder

[Dominik Mierzejewski]

On Monday, 16 December 2002, Dominik Mierzejewski wrote:
> On Monday, 16 December 2002, Arpi wrote:
> > Hi,
> > 
> > > Nothing major this time, just a few trivial fixes to silence some warnings.
> > 
> > i left these out by reason.
> > 
> > > -    printf("Found it! ID = 0x%X\n",prev);
> > > +    printf("Found it! ID = %p\n",prev);
> > 
> > prev isn't a pointer but a 6-digit component id.
> 
> Hmm... I'll have to recheck it then.

Looks like it is a pointer after all:
libmpcodecs/vd_qtvideo.c:96
[...]
    ComponentDescription desc;
    Component prev=NULL;
    CodecInfo cinfo;    // for ImageCodecGetCodecInfo() 
[...]

loader/qtx/qtxsdk/components.h:67
[...]
struct __attribute__((__packed__)) ComponentRecord {
    long                            data[1];
};
typedef struct ComponentRecord          ComponentRecord;
typedef ComponentRecord *               Component;
[...]

So the question is, what are we printing here? prev's address or contents?

PS. Same thing in line 155 of libmpcodecs/ve_qtvideo.c, CompressorComponent
is of the same type:
loader/qtx/qtxsdk/components.h:307
[...]
typedef Component                       CompressorComponent;
[...]

-- 
MPlayer RPMs maintainer: http://www.piorunek.pl/~dominik/linux/pkgs/mplayer/
"The Universe doesn't give you any points for doing things that are easy."
        -- Sheridan to Garibaldi in Babylon 5:"The Geometry of Shadows"