[MPlayer-dev-eng] [PATCH] rename -rnd to -random for greater consistency

Diego Biurrun diego at biurrun.de
Sat Dec 14 15:40:10 CET 2002


Hi!

Resending this after getting ignored on 29.11.2002:

I'd like to rename -rnd to -random to preserve the MPlayer style of
long, unabreviated options.  This should increase consistency.  Attila
agrees with me, Atmos thinks this might better be called -shuffle.  I
don't have strong feelings either way, as long as it's not -rnd or
-shfl.

OK to commit?

Diego


Index: parser-mpcmd.c
===================================================================
RCS file: /cvsroot/mplayer/main/parser-mpcmd.c,v
retrieving revision 1.2
diff -u -r1.2 parser-mpcmd.c
--- parser-mpcmd.c	12 Nov 2002 23:41:32 -0000	1.2
+++ parser-mpcmd.c	28 Nov 2002 23:33:34 -0000
@@ -224,12 +224,12 @@
 	    pt->loop = l;
 	    tmp = 1;
 	  }
-	} else if(strcasecmp(opt,"rnd") == 0) {
+	} else if(strcasecmp(opt,"random") == 0) {
 	  if(last_entry && last_entry->child)
 	    last_entry->flags |= PLAY_TREE_RND;
 	  else
 	    last_parent->flags |= PLAY_TREE_RND;
-	} else if(strcasecmp(opt,"nornd") == 0) {
+	} else if(strcasecmp(opt,"norandom") == 0) {
 	  if(last_entry && last_entry->child)
 	    last_entry->flags &= ~PLAY_TREE_RND;
 	  else
Index: DOCS/mplayer.1
===================================================================
RCS file: /cvsroot/mplayer/main/DOCS/mplayer.1,v
retrieving revision 1.270
diff -u -r1.270 mplayer.1
--- DOCS/mplayer.1	24 Nov 2002 17:30:55 -0000	1.270
+++ DOCS/mplayer.1	28 Nov 2002 23:33:35 -0000
@@ -281,7 +281,7 @@
 .B \-really\-quiet \ \ 
 Display even less output and status messages.
 .TP
-.B \-rnd \ \ 
+.B \-random \ \ 
 Play files in random order.
 .TP
 .B \-sdp



More information about the MPlayer-dev-eng mailing list