[MPlayer-dev-eng] [PATCH] v4l fixes

Alex Beregszaszi alex at galaktik.hu
Wed Aug 28 23:42:31 CEST 2002


Hi,

> Really, I previously overlooked tv_set_color_options in tv.c. Here is 
> the patch which does the eq setting via this function. I only moved the 
> option handling code from tvi_v4l.c to tv.c because I need the eq 
> setting in mencoder too, eg. for grabbing tv series with the same 
> settings. I also fixed the calculations in tv_set_color_options.
> 
> The rest of patch is unchanged.
Thanks for your patch, it's nice, but .. ;)

Sorry, the tv_set_color_options is a bit outdated and false, the valid
eq ranges are from -100 to +100.

Btw, please! Could you make 2 separate patches? One (first!) for the audio and others.
And after that the equalizer patch (and you don't need to add the colors setting,
only implement TVI_CONTROL_SET_* in tvi_v4l.c and i will do the rest).

Thanks.

-- 
Alex Beregszaszi  <alex at naxine.org>



More information about the MPlayer-dev-eng mailing list