[MPlayer-dev-eng] Are my patches being looked at? (vo_tdfxfb.c)

[Arpi]

Hi,

> Since this discussion is deemed useless for the list, I'll take it to
> personal mail. 
back to the list.
basic rule: coding topic belongs to the list. others not.

> As for the memset in the while loop, i just put that in there since
> the code didn't work without any sort of measureable delay.  I
> mentioned in the comment that inserting a printf also caused the code
> to work, but I figured that was dirty and not a good way to solve the
> problem.  Instead, it seemed that the card wasn't ready or there was
> something else happening, so i decided to put that initial memset into
> the while loop while checking the status of the card.  I could do some
> further testing to check how many times that is run if that really
> concerns you, but it does provide the required delay and doesn't cause
> anything bad other than maybe clearing the screen an extra couple of
> times.  This code isn't called very often, so I figured a couple of ms
> delay is acceptable.

do usec_sleep(10*1000) then. it's constant 10ms delay.
at least it won't burn the hardware :)

using memset() for delay is messy, and may won't be enough to delay several
ms on fast systems...


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu