[MPlayer-dev-eng] [PATCH] small ogg softsub fixes

Arpi arpi at thot.banki.hu
Wed Aug 28 20:05:29 CEST 2002


Hi,

> > Attached patch 
> > - fixes problems when new line is just '\n' and not '\r\n'.
> ok
dunno.
the author of teh original ogg subtitle support patch wrote a comment about
\n are not newline in ogg subs, but \r is. i found it strange but accept it.

actually this comemnt saying that:
        case '\n': // just ignore linefeeds for now
                   // their placement seems rather haphazard
but i've added case '\r': too as i modified teh code and \r was checked at
other place.

> > - disables code that removes html tags from subs (the code was not
> >   functional anyway)
> instead that removed the outcomming of if (!ignored)
ok

> > - increases SUB_MAX_TEXT. I have movie that has 6 lines of text in one
> >   scene.
> not committed this as i'm not really familiar with subtitle code.
> Someone should have a look at it.
it's ok to increase.
anyway a 6+ line subtitle covers the whole movie :)
it's more like teletext than subtitle :)


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu



More information about the MPlayer-dev-eng mailing list