[MPlayer-dev-eng] [PATCH] 64-bit -sb offsets
Alex Beregszaszi
alex at galaktik.hu
Wed Aug 28 18:37:08 CEST 2002
Hi,
> This patch adds CONF_TYPE_POSITION to cfgparser and changes -sb to be of
> said type. It uses off_t instead of int for values and is sensitive to
> sizeof(off_t) being greater than sizeof(int), as is the case for
> --enable-largefiles. It does this to fix a bug making it impossible to
> start playback beyond byte 2147483647--the value was being silently clipped
> by strtol.
>
> There may be cleaner ways of doing this, but I don't really see how within
> the current cfgparser system. Also this patch does not add
> m_config_get_position or m_config_set_position; as far as I can tell, they
> would never actually be called. Other options might benefit from being
> changed to CONF_TYPE_POSITION, but I'm not sure. All I know is, this works
> for me. If you need further tinkering before this patch becomes
> acceptable, just say so--I'd like an excuse to hack some more. ;^)
Thanks, applied.
--
Alex Beregszaszi <alex at naxine.org>
More information about the MPlayer-dev-eng
mailing list