[MPlayer-dev-eng] [PATCH] vo_tdfxfb.c clear screen and tiny image bug

[Burton Samograd]

When i found out about the tdfxfb driver it tried it and it didn't
work (caused the video output to come out only the size of a text
character on the main console).  I did some google searching and found
a couple of messages (i think from this list) saying that it was a bug
when mplayer was compiled with gcc 3.0 or higher.  So, in hopes of not
breaking anything I tried some things that I thought might work, since
it seemed that the values weren't being loaded properly when setting
up the 3dfx blt registers.  

Honestly, I don't know for sure why I have to do that, but I do know
that the bug is still there if I don't.  Maybe it has to do with code
alignment problems, or maybe the newer versions of gcc have a problem
with global variable aliasing or something of that sort.  And, since
it's code that *should* do nothing, it *shouldn't* break anything that
was working before.

Basically, I just looked at the problem and dug up some ideas from my
years of experience of working with buggy embedded compilers and that
just sort of popped up in my head and it solved the problem and
hopefully didn't break anything. :)  

burton

On Wed, Aug 28, 2002 at 06:05:47PM +0200, Alex Beregszaszi wrote:
> Hi,
> 
> > I already sent part of this patch earlier today, but this one also
> > fixes one of the comments on the wishlist that was just sent out
> > (clearing the screen).
> > 
> > burton
> 
> As currently
> 1, I can't test your patch,
> 2, there are not so many 3dfx users,
> 3, and the patch seems to be ok, I commited it.
> 
> The only thing that i cant understand is that 'must be a gcc 3.0+ bug'.
> Why do you set up unused variables?
> 
> -- 
> Alex Beregszaszi  <alex at naxine.org>
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng