[MPlayer-dev-eng] [PATCH] v4l fix

Alex Beregszaszi alex at galaktik.hu
Wed Aug 28 18:17:47 CEST 2002


Hi,

> Ti,
> 
> This patch fixes the v4l audio volume setting and adds few options for 
> tv card mixer and video equalizer.

I have comments/requests:
Please make separate patches for DOCS and code.
The audio fix part looks ok, willing to commit it.
The video equalizer part is a hack and it isn't acceptable!
Please use our video equalizer system, have a look at libmpcodecs/dec_video.c
In the past i've implemented equalizing into v4l capturer, where is it now?

You should make a new patch that i can commit.

goth,diego,gabu: after the new patch please commit the docs part.

-- 
Alex Beregszaszi  <alex at naxine.org>



More information about the MPlayer-dev-eng mailing list