[MPlayer-dev-eng] [PATCH] compiler warnings fixes

[Dominik Mierzejewski]

On Tuesday, 27 August 2002, Ponekker Zoltan wrote:
> Hali

Hello,

> > mplayer-gui.patch:
> > 	fixes missing newlines and #includes, unused variables, incompatible
> > 	types and missing declarations in GUI code
> 
> Thanksz, applied with some small changes ... :)

Great. However, it looks as if you missed a few things (patch attached).

My manpage for XGetWindowProperty says that 9th parameter should be int *,
not unsigned long *.

-- 
MPlayer RPMs maintainer: http://www.piorunek.pl/~dominik/linux/pkgs/mplayer/
"The Universe doesn't give you any points for doing things that are easy."
        -- Sheridan to Garibaldi in Babylon 5:"The Geometry of Shadows"
-------------- next part --------------
--- MPlayer-20020827/Gui/wm/wsxdnd.c.gui	Tue Aug 27 01:32:03 2002
+++ MPlayer-20020827/Gui/wm/wsxdnd.c	Tue Aug 27 02:01:47 2002
@@ -5,6 +5,7 @@
 #include "ws.h"
 #include "wsxdnd.h"
 
+#include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 
@@ -158,7 +159,8 @@
       int offset = 0;
       Atom* ret_buff;
       Atom ret_type;
-      unsigned long ret_format,ret_items;
+      int ret_format;
+      unsigned long ret_items;
       /* while there is data left...*/
       while(ret_left){
 	XGetWindowProperty(wsDisplay,event->data.l[0],_XA_XdndTypeList,