[MPlayer-dev-eng] [PATCH] mplayer compilation with icc

[Joey Parrish]

On Fri, Aug 23, 2002 at 01:20:34AM +0200, Arpi wrote:
> Hi,
> -  int error(void) {
> -    vorbis_comment_clear(&vc);
> -    vorbis_info_clear(&ov->vi);
> -    free(ov);
> -    return 0;
> +#define error() { \
> +    vorbis_comment_clear(&vc); \
> +    vorbis_info_clear(&ov->vi); \
> +    free(ov); \
> +    return 0; \
> 
> it is not equivalent!
> the later will exit from the _parent_ function with return 0;

But it is equivalent because of this other hunk:
-    return error();
+    error();

both before and after the full patch, this piece behaves the same.

Can whoever wrote this line below please clarify it?
ao_plugin_data.len=(int)(((double)ao_plugin_data.len)*=pl_format.sz_mult);

As for the static inlines, I know it was a cheap fix, but my point was
to show everyone which areas of the code are otherwise incompatible with
icc.  My hope was that someone more capable than me might know a _good_
solution.  Any takers?  Some parts that are declared static inline make
icc complain at link time that it cannot find them.

> anyway you should use #ifndef USING_ICC instead of #if !defined(USING_ICC)
> it's cleaner...

Alright, I'll use that in my next version of this patch.
I have yet to find a preprocessor variable in icc that would suffice.
My access to a machine with icc is cut off for the moment, but I will
download it at home soon and continue to work with it.

The -f flags don't stricly need to be removed, I think.  If I remember
correctly, they generated warnings but did not break the compile.

The inb and outb hunk is really strange, I must agree.  I took the asm
code from gnu headers, if I recall.  :)  But the thing that annoys me is
that inw and outw got no complaints from icc.

So, to make a nice todo list for myself, how does this look:

. find a better define than USING_ICC
. find a better fix getting icc to link the static inlines
. do not remove -f flags from makefiles
. change if !defined() to ifndef

Anything I'm missing?

Thanks,
--Joey

-- 

"All you need is love." --Darth Vader