[MPlayer-dev-eng] Some trivial compiler warning fixes

Dominik Mierzejewski dominik at rangers.eu.org
Sat Aug 17 22:56:34 CEST 2002


Here are some patches I made for my RPM packages:
Patch #1 fixes some warnings for GUI code
Patch #2 removes -g flag from CFLAGS in some places
Patch #3 fixes some warnings for mplayer code

All apply cleanly against current CVS.
 
-- 
MPlayer RPMs maintainer: http://www.piorunek.pl/~dominik/linux/pkgs/mplayer/
"The Universe doesn't give you any points for doing things that are easy."
        -- Sheridan to Garibaldi in Babylon 5:"The Geometry of Shadows"
-------------- next part --------------
--- MPlayer-0.90pre6/Gui/mplayer/gtk/menu.h.gui	Wed Nov 14 18:48:38 2001
+++ MPlayer-0.90pre6/Gui/mplayer/gtk/menu.h	Sat Aug 10 20:00:18 2002
@@ -10,4 +10,4 @@
 extern GtkWidget * AddSeparator( GtkWidget * Menu );
 extern GtkWidget * create_PopUpMenu( void );
 
-#endif
\ No newline at end of file
+#endif
--- MPlayer-0.90pre6/Gui/mplayer/gtk/opts.h.gui	Thu Jul 25 22:26:37 2002
+++ MPlayer-0.90pre6/Gui/mplayer/gtk/opts.h	Sat Aug 10 20:00:18 2002
@@ -14,4 +14,4 @@
 
 extern void ShowPreferences( void );
 
-#endif
\ No newline at end of file
+#endif
--- MPlayer-0.90pre6/Gui/mplayer/gtk/eq.h.gui	Thu Jul 25 22:26:37 2002
+++ MPlayer-0.90pre6/Gui/mplayer/gtk/eq.h	Sat Aug 10 20:00:18 2002
@@ -9,4 +9,4 @@
 extern GtkWidget * create_Equalizer( void );
 extern void ShowEqualizer( void );
 
-#endif
\ No newline at end of file
+#endif
--- MPlayer-0.90pre6/Gui/mplayer/gtk/pl.h.gui	Fri Jul 12 02:53:26 2002
+++ MPlayer-0.90pre6/Gui/mplayer/gtk/pl.h	Sat Aug 10 20:00:18 2002
@@ -11,4 +11,4 @@
 
 extern GtkWidget * create_PlayList (void);
 
-#endif
\ No newline at end of file
+#endif
--- MPlayer-0.90pre6/Gui/mplayer/play.c.gui	Mon Aug  5 03:14:14 2002
+++ MPlayer-0.90pre6/Gui/mplayer/play.c	Sat Aug 10 20:00:18 2002
@@ -1,6 +1,7 @@
 #include <inttypes.h>
 #include <stdlib.h>
 #include <stdio.h>
+#include <string.h>
 
 #include <unistd.h>
 #include <signal.h>
--- MPlayer-0.90pre6/Gui/app.c.gui	Tue May 28 13:55:15 2002
+++ MPlayer-0.90pre6/Gui/app.c	Sat Aug 10 20:00:18 2002
@@ -13,6 +13,8 @@
 #include "mplayer/mplayer.h"
 #include "interface.h"
 
+extern char *get_path(char *);
+
 listItems   appMPlayer;
 
 char      * skinDirInHome=NULL;
-------------- next part --------------
--- MPlayer-20020719/libavcodec/Makefile.nodebug	Fri Jul 19 13:03:56 2002
+++ MPlayer-20020719/libavcodec/Makefile	Fri Jul 19 13:07:26 2002
@@ -7,8 +7,8 @@
 VPATH=$(SRC_PATH)/libavcodec
 
 # NOTE: -I.. is needed to include config.h
-CFLAGS= $(OPTFLAGS) -Wall -g -DHAVE_AV_CONFIG_H -I.. -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_GNU_SOURCE
-LDFLAGS= -g
+CFLAGS= $(OPTFLAGS) -Wall -DHAVE_AV_CONFIG_H -I.. -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_GNU_SOURCE
+LDFLAGS=
 
 OBJS= common.o utils.o mem.o allcodecs.o \
       mpegvideo.o h263.o jrevdct.o jfdctfst.o \
--- MPlayer-20020719/Makefile.nodebug	Fri Jul 19 13:06:51 2002
+++ MPlayer-20020719/Makefile	Fri Jul 19 13:06:51 2002
@@ -220,7 +220,7 @@
 $(MENCODER_DEP): version.h
 
 $(PRG_CFG): version.h codec-cfg.c codec-cfg.h
-	$(CC) $(CFLAGS) -g codec-cfg.c mp_msg.c -o $(PRG_CFG) -DCODECS2HTML
+	$(CC) $(CFLAGS) -Wall codec-cfg.c mp_msg.c -o $(PRG_CFG) -DCODECS2HTML
 
 install: $(ALL_PRG)
 ifeq ($(VIDIX),yes)
-------------- next part --------------
--- MPlayer-0.90pre6/libmpcodecs/vf.c.warn	Sat Aug  3 00:55:54 2002
+++ MPlayer-0.90pre6/libmpcodecs/vf.c	Sat Aug 10 18:01:12 2002
@@ -2,11 +2,11 @@
 #include <stdlib.h>
 #include <string.h>
 
+#include "../config.h"
 #ifdef HAVE_MALLOC_H
 #include <malloc.h>
 #endif
 
-#include "../config.h"
 #include "../mp_msg.h"
 
 #include "img_format.h"
--- MPlayer-0.90pre6/libmpcodecs/vd_svq1.c.warn	Sun Jun 23 13:34:54 2002
+++ MPlayer-0.90pre6/libmpcodecs/vd_svq1.c	Sat Aug 10 18:01:12 2002
@@ -5,6 +5,9 @@
 #include "mp_msg.h"
 
 #include "vd_internal.h"
+#ifdef USE_LIBAVCODEC
+#include "../libavcodec/avcodec.h"
+#endif
 
 static vd_info_t info = {
 	"SVQ1 (Sorenson v1) Video decoder",
--- MPlayer-0.90pre6/libmpcodecs/ve_divx4.c.warn	Sat Apr 27 03:17:42 2002
+++ MPlayer-0.90pre6/libmpcodecs/ve_divx4.c	Sat Aug 10 18:01:12 2002
@@ -24,6 +24,7 @@
 
 extern int pass;
 extern char* passtmpfile;
+extern void mencoder_write_chunk(aviwrite_stream_t *s,int len,unsigned int flags);
 
 #include <encore2.h>
 
--- MPlayer-0.90pre6/libmpcodecs/ve_lavc.c.warn	Mon Jul  8 23:34:24 2002
+++ MPlayer-0.90pre6/libmpcodecs/ve_lavc.c	Sat Aug 10 18:01:12 2002
@@ -26,6 +26,7 @@
 #endif
 
 extern int pass;
+extern void mencoder_write_chunk(aviwrite_stream_t *s,int len,unsigned int flags);
 
 //===========================================================================//
 
--- MPlayer-0.90pre6/libmpcodecs/ve_libdv.c.warn	Sat Apr 13 21:14:31 2002
+++ MPlayer-0.90pre6/libmpcodecs/ve_libdv.c	Sat Aug 10 18:01:12 2002
@@ -23,6 +23,8 @@
 
 #include <libdv/dv.h>
 
+extern void mencoder_write_chunk(aviwrite_stream_t *s,int len,unsigned int flags);
+
 #ifndef DV_WIDTH
 #define DV_WIDTH       720
 #define DV_PAL_HEIGHT  576
--- MPlayer-0.90pre6/libmpcodecs/ve_rawrgb.c.warn	Mon Apr 29 11:53:30 2002
+++ MPlayer-0.90pre6/libmpcodecs/ve_rawrgb.c	Sat Aug 10 18:01:12 2002
@@ -16,6 +16,8 @@
 #include "mp_image.h"
 #include "vf.h"
 
+extern void mencoder_write_chunk(aviwrite_stream_t *s,int len,unsigned int flags);
+
 //===========================================================================//
 
 struct vf_priv_s {
--- MPlayer-0.90pre6/libmpcodecs/ve_vfw.c.warn	Mon May 13 23:18:52 2002
+++ MPlayer-0.90pre6/libmpcodecs/ve_vfw.c	Sat Aug 10 18:01:12 2002
@@ -18,6 +18,8 @@
 #include "mp_image.h"
 #include "vf.h"
 
+extern void mencoder_write_chunk(aviwrite_stream_t *s,int len,unsigned int flags);
+
 //===========================================================================//
 
 #include "dll_init.h"
--- MPlayer-0.90pre6/libmpcodecs/vd_real.c.warn	Thu Jul 18 01:28:37 2002
+++ MPlayer-0.90pre6/libmpcodecs/vd_real.c	Sat Aug 10 18:01:12 2002
@@ -11,6 +11,9 @@
 
 #include "vd_internal.h"
 
+#include "../loader/ldt_keeper.h"
+#include "../loader/wine/winbase.h"
+
 static vd_info_t info = {
 	"RealVideo decoder",
 	"real",
--- MPlayer-0.90pre6/libmpcodecs/vf_rectangle.c.warn	Sun Aug  4 04:21:50 2002
+++ MPlayer-0.90pre6/libmpcodecs/vf_rectangle.c	Sat Aug 10 18:01:56 2002
@@ -4,6 +4,8 @@
 #include "mp_image.h"
 #include "vf.h"
 
+#include "../libvo/fastmemcpy.h"
+
 struct vf_priv_s {
     int x, y, w, h;
 };
--- MPlayer-0.90pre6/postproc/rgb2rgb_template.c.warn	Sat Jun 29 23:43:28 2002
+++ MPlayer-0.90pre6/postproc/rgb2rgb_template.c	Sat Aug 10 18:01:12 2002
@@ -15,6 +15,8 @@
 #warning You have misconfigured system and probably will lose performance!
 #endif
 
+#include "../libvo/fastmemcpy.h"
+
 #undef PREFETCH
 #undef MOVNTQ
 #undef EMMS
--- MPlayer-0.90pre6/vidix/drivers/mga_vid.c.warn	Fri Jul 26 00:52:51 2002
+++ MPlayer-0.90pre6/vidix/drivers/mga_vid.c	Sat Aug 10 18:01:12 2002
@@ -685,7 +685,7 @@
 
 int vixConfigPlayback(vidix_playback_t *config)
 {
-	int i;
+	unsigned int i;
 	int x, y, sw, sh, dw, dh;
 	int besleft, bestop, ifactor, ofsleft, ofstop, baseadrofs, weight, weights;
 #ifdef CRTC2


More information about the MPlayer-dev-eng mailing list