[MPlayer-dev-eng] [PATCH] mpdvdkit2 cygwin support

Joey Parrish joey at yunamusic.com
Thu Aug 15 04:34:38 CEST 2002


Hello,

On Thu, Aug 15, 2002 at 12:06:50AM +0200, Arpi wrote:
> hmm. are you sure this patch is ok and working???
> 
> the DVDOpen() function's structure:
> 
>     ret = stat( path, &fileinfo );
> ...
>     /* First check if this is a block/char device or a file*/
>     if( S_ISBLK( fileinfo.st_mode ) ||
>         S_ISCHR( fileinfo.st_mode ) ||
>         S_ISREG( fileinfo.st_mode ) ) {
> 
> 	(... open as raw device or image file using DVDOpenImageFile() ...)
> 
>     } else if( S_ISDIR( fileinfo.st_mode ) ) {
> 
>         /**
>          * If we're being asked to open a directory, check if that directory
>          * is the mountpoint for a DVD-ROM which we can use instead.
>          */
> 
> (here you added:)
> 
> #elif defined(WIN32)
>         dev_name = strdup(path);
>         auth_drive = DVDOpenImageFile( path, have_css );
> #endif
> 
>         /**
>          * Otherwise, we now try to open the directory tree instead.
>          */
>         return DVDOpenPath( path );
>     }
> 
> it would work only if cygwin handles DVD device as a directory(!) (S_ISDIR()
> true) but it's really a raw device and can be open()'ed and read()'ed as
> raw sectors? otherwise teh fallback method (DVDOpenPath()) would be OK.

> A'rpi / Astral & ESP-team

I wish I still had saved a copy of the errors that mplayer was
returning without this patch.  I'm away from home for a few days
right now.  If I can call home and get one of my roomates to
help me out, maybe I can get a remote shell on my cygwin testing
machine and get back to you with the details of this whole thing.
I probably should have said exactly why this was needed in the
first place, but I was in a hurry to submit.  If I can't get this
done from my vacation, I'll start a new thread to get your attention
when I get home next week.  Is that OK?

Thanks for waiting,
--Joey

-- 

"All you need is love." --Darth Vader



More information about the MPlayer-dev-eng mailing list