[MPlayer-dev-eng] FW: mplayer patch for DirectFB-0.9.13

[Felix Buenemann]

On Tuesday 30 July 2002 19:53, Jiří Svoboda wrote:
> Could it be this way?
Looks nice, but I have some thoughts:
 - Shouldn't it be major version *1000 instead of *100 in configure?
 - It would IMHO be better to directly use #if DIRECTFBVERSION > n in the code 
instead of doing this unneeded remapping to HAVE_DIRECTFBn

> 		JS
>
> > -----Original Message-----
> > From: mplayer-dev-eng-admin at mplayerhq.hu
> > [mailto:mplayer-dev-eng-admin at mplayerhq.hu] On Behalf Of
> > Felix Buenemann
> > Sent: Monday, July 29, 2002 2:21 PM
> > To: mplayer-dev-eng at mplayerhq.hu
> > Subject: Re: [MPlayer-dev-eng] FW: mplayer patch for DirectFB-0.9.13
> >
> > On Monday 29 July 2002 09:06, Jiri Svoboda wrote:
> > > Hi,
> > >
> > > > Hmm, doesn't directfb declare a version string as some
> >
> > cpp macro in
> >
> > > > their headers? IMHO adding a new configure check for each
> >
> > and every
> >
> > > > new directfb
> > > > version is a bit ugly.
> > >
> > > I think no, it's declared as extern const unsigned int ...
> > >
> > > But small app could return version string - could this be solution?
> >
> > yea, proably generate it on the fly from embedded sources in
> > configure and
> > then do something like #define DFB_VERSION 000913 or
> > something like that into
> > config.h.
> >
> > > 			JS
> >
> > --
> > Best Regards,
> >         Atmos

-- 
Best Regards,
        Atmos
____________________________________________
- MPlayer Developer - http://mplayerhq.hu/ -
____________________________________________