[MPlayer-dev-eng] [PATH] libmpdvdkit and tvi_bsdbt848 on NetBSD

[Steven M. Schultz]

Hi!

> From: Arpi <arpi at thot.banki.hu>
> ok, what about this:
> 
>   _def_dvd_linux='#undef HAVE_LINUX_DVD_STRUCT'
>   _def_dvd_bsd='#undef HAVE_BSD_DVD_STRUCT'
>   if linux || netbsd || openbsd ; then
>     _def_dvd_linux='#define HAVE_LINUX_DVD_STRUCT 1'
>   else
>     if freebsd || bsdos ; then
>      _def_dvd_bsd='#define HAVE_BSD_DVD_STRUCT 1'
>     fi
>   fi
> 
> so, if i understood right, netbsd and openbsd has linux-style dvd struct,
> while bsd/os, freebsd has bsd-style?

	Close, but slightly reversed ;)

	bsd/os has linux-style dvd struct.

	freebsd, netbsd, openbsd have bsd-style.

	So what I think needs to be done is something like:

 _def_dvd_linux='#undef HAVE_LINUX_DVD_STRUCT'
 _def_dvd_bsd='#undef HAVE_BSD_DVD_STRUCT'
 if linux || bsdos; then
   _def_dvd_linux='#define HAVE_LINUX_DVD_STRUCT 1'
 else
    if netbsd || openbsd || freebsd; then
     _def_dvd_bsd='#define HAVE_BSD_DVD_STRUCT 1'
    fi
  fi

	Someone who has a openbsd or netbsd system would have to confirm
	that is correct for their system

	The only change to libmpdvdkit was in the  ioctl.c file:

--- ioctl.c.dist        Wed Apr 24 12:28:03 2002
+++ ioctl.c     Wed Apr 24 17:41:11 2002
@@ -53,7 +53,9 @@
 #   include <dvd.h>
 #endif
 #ifdef DVD_STRUCT_IN_BSDI_DVDIOCTL_DVD_H
-#   include <BSDI_dvdioctl/dvd.h>
+#   undef DVD_STRUCT_IN_DVD_H
+#   define HAVE_LINUX_DVD_STRUCT
+#   include <dvd.h>
 #endif
 #ifdef SYS_BEOS
 #   include <malloc.h>

	I recognize that code - it's what I did with the Videolan.Org folks ;)
	Just need to change the pathname of the 'dvd.h' file from
	BSDI_dvdioctl/dvd.h to simply dvd.h

> about the idea of disabling libmpdvdkit:
> you can disable it, if you want. but i don't agree on disabling it if
> libdvdread/libdvdcss found, as libdvdkit has some critical and some usefull
> patches applied, still missing from official libdvd* releases.
> 
> also note, that mplayer won't work with ogle's dvdcss 1.0

	Oh, ok.   I've both libdvdcss-0.0.3.ogle3 (from Ogle) and 
	libdvdcss-1.1.0 (from Videolan.Org) installed on the system.   MPlayer
	is using 0.0.3.ogle3 I believe.

	Cheers,
	Steven Schultz
	sms at 2bsd.com