[MPlayer-dev-eng] [PATCH] improved vo_svga.c

Arpi arpi at thot.banki.hu
Thu Apr 18 17:44:57 CEST 2002


Hi,

> This patch replaces vo_svga.c with an improved version that does not use
> vgagl library, supports direct rendering and page flipping, and is
> generally a lot faster.

thanks, applied to CVS.

btw it seems to be a bit outdated for me, at least doesn't follow the new
libvo rules. please take a look at DOCS/tech/libvo.txt
especially preinit vs. config, and query_format return values

imho, the checksupportedmodes() call should be done in preinit(),
and if it fail then return error from preinit, so mplayer can terminate
before setting up all teh filters, codecs etc.
as query_format and config(0 are called after preinit, the
checksupportedmodes( could be removed there. be care, that config() can be
called zero, 1 or more times! and shouldn't fail...


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu



More information about the MPlayer-dev-eng mailing list