[MPlayer-dev-eng] [PATCH] current pl_surround in mplayer CVS breaks playlist

Arpi arpi at thot.banki.hu
Sun Apr 7 03:12:20 CEST 2002


Hi,

> what's with this off-by-one error in sound? i've seen a few suggested
> fixes, but how about just something like length &= ~1? :)

it's bad
why?
- samplesize could be 1 (8bit audio)
- badly rounded len is even worse, when len % (samplesize*channels) != 0

len should be rounded up to n*(samplesize*channels), at the right place.


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu



More information about the MPlayer-dev-eng mailing list