[MPlayer-dev-eng] RPMs for MPlayer-0.50

Arpi arpi at thot.banki.hu
Fri Oct 19 01:36:39 CEST 2001


Hi,

> Did you even look at what I did?  That's basically it, for the cases that 
not really. anyway i hopes this will be the answer :)

now i've ran through your 4500 line patch...
at first look, you did i said don't do.
it's ok to move things to new file and include as a template. the
cleaner solution, but it will mess up cvs. you should ask me to rename
these files in teh cvs, and add a dummy file with original name including
these. this way we'll keep cvs log and diffs of that code.
then you can make the patch. btw i can do that later, applying youd patch
to a second repository, do the renaming in the main tree and then merge back.
ok.

btw you did a good work. but someone of us should review it before
commiting, i feel some problems in it, but i've no time now to check, and as
atmos said, it's not up-to-date and ready yet, so reviewing it ha sno sense
now. but i'll see, and mayeb tomorrow i'll commit some already clean parts
of your patch. so it's easier to continue.

> The only compile time option I had at the moment was to add/remove certain 
> cpu-specific optimizations, but I didn't make a total runtime cpu detection 
> removing option.  How important is that for you?
not very important, but would be good. if someone configures optimization
and recompile mplayer, why to have never used code compiled in and use
unneeded extra function pointer indexing?


A'rpi / Astral & ESP-team

--
mailto:arpi at thot.banki.hu
http://esp-team.scene.hu



More information about the MPlayer-dev-eng mailing list