[MPlayer-dev-eng] Postprocessing in GPL

[Michael Niedermayer]

Hi

On Thursday 11 October 2001 11:54, Arpi wrote:
> > 2. What is the brightness filter good for? In some of my movie samples it
> > actually degraded image quality by making it too bright.
>
> same for me :(
> it will be optional, so users can enable if they need it.
the first picture postprocess gets is allways completly black so the 
statistics get messed up and it takes some time until the brightness is back 
to normal (ill fix that)

> > 2b. On another movie that I used to check how good deblocking works, I
> > can see that the brightness filter is only used on 236 of 240 vertical
> > pixels so there stays a 4 pixel high dark band on the bottom of the
> > picture,I guess also a bug.
>
> yes, it's a bug. somewhere i saw a 4-line memcpy(). as memcpy just copies,
> it won't scale brightness.
ok will be fixed 

> btw speed of new postprocess is very good, compared to old opendivx
> postprocess.c
its even faster if u kill #define MORE_TIMING that one requires surpisingly 
alot of cpu cycles

Michael